Page MenuHomePhabricator

Bug 1682030 - Remove PPluginWidget. r=jmathies!
ClosedPublic

Authored by handyman on Mar 4 2021, 12:16 AM.

Details

Summary

Removes the NPAPI plugin widget actor and its proxy, as part of removing all of NPAPI plugin support.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 308082
Build 401733: arc lint + arc unit

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 4 defects in the diff 407987:

  • 1 build error found by clang-tidy
  • 3 defects found by code coverage analysis

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

nika added a subscriber: nika.

r+ for the sync-messages changes

handyman retitled this revision from Bug 1682030 - Remove PPluginWidget. DONTBUILD r=jmathies! to Bug 1682030 - Remove PPluginWidget. r=jmathies!.Mar 4 2021, 6:28 PM
This revision is now accepted and ready to land.Mar 12 2021, 6:04 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.

handyman retitled this revision from Bug 1682030 - Remove PPluginWidget. r=jmathies! to Bug 1682030 - Remove PPluginWidget. r=jmathies!.
handyman edited the summary of this revision. (Show Details)

Code analysis found 4 defects in the diff 413990:

  • 1 build error found by clang-tidy
  • 3 defects found by code coverage analysis

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 4 defects in the diff 421873:

  • 1 build error found by clang-tidy
  • 3 defects found by code coverage analysis

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 4 defects in the diff 422344:

  • 1 build error found by clang-tidy
  • 3 defects found by code coverage analysis

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This revision is now accepted and ready to land.Apr 6 2021, 12:59 AM

Code analysis found 4 defects in the diff 422914:

  • 1 build error found by clang-tidy
  • 3 defects found by code coverage analysis

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 4 defects in the diff 423022:

  • 1 build error found by clang-tidy
  • 3 defects found by code coverage analysis

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.