Removes the PPluginSurface actor used for windowed plugins, as part of removing all of NPAPI plugin support. SharedDIB is then unused and is also removed.
Details
Details
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable - Build Status
Buildable 308081 Build 401732: arc lint + arc unit
Event Timeline
Comment Actions
Code analysis found 3 defects in the diff 407986:
- 3 defects found by code coverage analysis
In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?
- You can file a bug blocking Bug 1415824 for untested files that should be tested.
- You can file a bug blocking Bug 1415819 for untested files that should be removed.
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.
Comment Actions
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other.
Comment Actions
Code analysis found 3 defects in the diff 413988:
- 3 defects found by code coverage analysis
In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?
- You can file a bug blocking Bug 1415824 for untested files that should be tested.
- You can file a bug blocking Bug 1415819 for untested files that should be removed.
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.
Comment Actions
Code analysis found 3 defects in the diff 421872:
- 3 defects found by code coverage analysis
In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?
- You can file a bug blocking Bug 1415824 for untested files that should be tested.
- You can file a bug blocking Bug 1415819 for untested files that should be removed.
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.
Comment Actions
Code analysis found 3 defects in the diff 422342:
- 3 defects found by code coverage analysis
In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?
- You can file a bug blocking Bug 1415824 for untested files that should be tested.
- You can file a bug blocking Bug 1415819 for untested files that should be removed.
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.
Comment Actions
Code analysis found 3 defects in the diff 422913:
- 3 defects found by code coverage analysis
In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?
- You can file a bug blocking Bug 1415824 for untested files that should be tested.
- You can file a bug blocking Bug 1415819 for untested files that should be removed.
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.
Comment Actions
Code analysis found 3 defects in the diff 423021:
- 3 defects found by code coverage analysis
In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?
- You can file a bug blocking Bug 1415824 for untested files that should be tested.
- You can file a bug blocking Bug 1415819 for untested files that should be removed.
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.