Page MenuHomePhabricator

Bug 1682030 - remove nsIPluginWidget
AbandonedPublicDraft

Authored by handyman on Dec 11 2020, 7:48 PM.

Details

Reviewers
None
Bugzilla Bug ID
1682030

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
SeverityLocationCodeMessage
Errordom/plugins/base/nsNPAPIPluginInstance.cpp:244clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.cpp:249clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:81clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:109clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:110clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginHost.cpp:26clang-diagnostic-errorBuild Error
Errortoolkit/xre/nsEmbedFunctions.cpp:528clang-diagnostic-errorBuild Error
Unit
No Test Coverage

Event Timeline

handyman created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 11 2020, 7:49 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 7 defects in the diff 378031:

  • 7 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 378031, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman updated this revision to Diff 378166.
handyman edited the summary of this revision. (Show Details)

Code analysis found 7 defects in the diff 378166:

  • 7 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

You have touched the documentation in diff 378166, you can find it rendered here for a week.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.