Page MenuHomePhabricator

Bug 1682030 - Remove nsJSNPRuntime
AbandonedPublicDraft

Authored by handyman on Dec 11 2020, 7:43 PM.

Details

Reviewers
None
Bugzilla Bug ID
1682030

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
SeverityLocationCodeMessage
Errordom/plugins/base/nsNPAPIPluginInstance.cpp:298clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.cpp:303clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:84clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:114clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsNPAPIPluginInstance.h:115clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginHost.cpp:26clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2281clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2285clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2297clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2298clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2301clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2510clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2577clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2581clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2591clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2599clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2845clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.cpp:2893clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:122clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:220clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:248clang-diagnostic-errorBuild Error
Errordom/plugins/base/nsPluginInstanceOwner.h:292clang-diagnostic-errorBuild Error
Errormfbt/RefPtr.h:49clang-diagnostic-errorBuild Error
Errormfbt/RefPtr.h:50clang-diagnostic-errorBuild Error
Errortoolkit/xre/nsEmbedFunctions.cpp:528clang-diagnostic-errorBuild Error
Unit
No Test Coverage

Event Timeline

handyman created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 11 2020, 7:43 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 97 defects in the diff 378019:

  • 2 defects found by code coverage analysis
  • 95 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman edited the summary of this revision. (Show Details)

Code analysis found 97 defects in the diff 378155:

  • 2 defects found by code coverage analysis
  • 95 build errors found by clang-tidy

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-mozlint-file-perm failed, but we could not detect any issue.
Please check this task manually.

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

  • You can file a bug blocking Bug 1415824 for untested files that should be tested.
  • You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.