Differential D99509

Bug 1682030 - remove brokered plugin functions
AbandonedPublicDraft
Actions

Authored by handyman on Dec 11 2020, 7:33 PM.

Details

Reviewers: None
Bugzilla Bug ID: 1682030

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Lint

No Lint Coverage

Severity	Location	Code	Message
Warning	dom/plugins/ipc/FunctionBroker.cpp:1	no-coverage	code coverage analysis
Warning	dom/plugins/ipc/FunctionBrokerChild.cpp:1	no-coverage	code coverage analysis
Warning	dom/plugins/ipc/FunctionBrokerIPCUtils.cpp:1	no-coverage	code coverage analysis
Warning	dom/plugins/ipc/PluginModuleChild.cpp:1	no-coverage	code coverage analysis

Unit

No Test Coverage

Event Timeline

handyman planned changes to this revision.Dec 11 2020, 7:33 PM

handyman created this revision.

Herald added a project: secure-revision. · View Herald TranscriptDec 11 2020, 7:33 PM

Harbormaster completed remote builds in B268743: Diff 377993.Dec 11 2020, 7:33 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 11 2020, 7:33 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

handyman added a child revision: D99510: Bug 1682030 - remove PStreamNofity and PBrowserStream and AStream.Dec 11 2020, 7:34 PM

Code analysis found 4 defects in the diff 377993:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman updated this revision to Diff 378132.Dec 12 2020, 12:39 AM

handyman edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B268851: Diff 378132.Dec 12 2020, 12:39 AM

handyman planned changes to this revision.Dec 12 2020, 12:39 AM

Code analysis found 4 defects in the diff 378132:

4 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman abandoned this revision.Mar 3 2021, 11:44 PM