Differential D99506

Bug 1682030 - delete testplugin
AbandonedPublicDraft
Actions

Authored by handyman on Dec 11 2020, 7:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 5 2023, 7:40 AM

	Unknown Object (File)
	Mar 19 2023, 10:07 PM

Subscribers

Details

Reviewers: None
Bugzilla Bug ID: 1682030

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Lint

No Lint Coverage

Severity	Location	Code	Message
Warning	dom/plugins/test/testplugin/nptest.cpp:1	no-coverage	code coverage analysis
Warning	dom/plugins/test/testplugin/nptest_gtk2.cpp:1	no-coverage	code coverage analysis
Warning	dom/plugins/test/testplugin/nptest_utils.cpp:1	no-coverage	code coverage analysis
Warning	dom/plugins/test/testplugin/nptest_windows.cpp:1	no-coverage	code coverage analysis
Warning	dom/plugins/test/testplugin/secondplugin/nptest_name.cpp:1	no-coverage	code coverage analysis

Unit

No Test Coverage

Event Timeline

handyman planned changes to this revision.Dec 11 2020, 7:28 PM

handyman created this revision.

Herald added a project: secure-revision. · View Herald TranscriptDec 11 2020, 7:28 PM

Harbormaster completed remote builds in B268740: Diff 377990.Dec 11 2020, 7:28 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 11 2020, 7:28 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

handyman added a child revision: D99508: Bug 1682030 - clean up dom/plugins/test mochitests and reftests.Dec 11 2020, 7:33 PM

Code analysis found 5 defects in the diff 377990:

5 defects found by code coverage analysis

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

handyman abandoned this revision.Mar 3 2021, 11:41 PM

Revision Contents
Changeset List

Path

Size

dom/

plugins/

test/

crashtests/

crashtests.list

9 lines

mochitest/

12 lines

browser_bug1163570.js

browser_pluginscroll.js

browser_tabswitchbetweenplugins.js

test_plugin_scroll_invalidation.html

2 lines

testplugin/

flashplugin/

nptest_name.cpp

nptest_droid.cpp

nptest_gtk2.cpp

nptest_macosx.mm

nptest_name.cpp

nptest_platform.h

nptest_utils.cpp

nptest_windows.cpp

secondplugin/

nptest_name.cpp

testplugin.mozbuild

Diff 377990

dom/plugins/test/crashtests/539897-1.html

Loading...

dom/plugins/test/crashtests/540114-1.html

Loading...

dom/plugins/test/crashtests/570884.html

Loading...

dom/plugins/test/crashtests/598862.html

Loading...

dom/plugins/test/crashtests/626602-1.html

Loading...

dom/plugins/test/crashtests/crashtests.list

Loading...

dom/plugins/test/mochitest/browser.ini

Loading...

dom/plugins/test/mochitest/browser_bug1163570.js

Loading...

dom/plugins/test/mochitest/browser_pluginscroll.js

Loading...

dom/plugins/test/mochitest/browser_tabswitchbetweenplugins.js

Loading...

dom/plugins/test/mochitest/test_plugin_scroll_invalidation.html

Loading...

dom/plugins/test/moz.build

Loading...

dom/plugins/test/testplugin/Info.plist

Loading...

dom/plugins/test/testplugin/README

Loading...

dom/plugins/test/testplugin/flashplugin/Info.plist

Loading...

dom/plugins/test/testplugin/flashplugin/moz.build

Loading...

dom/plugins/test/testplugin/flashplugin/nptest.def

Loading...

dom/plugins/test/testplugin/flashplugin/nptest.rc

Loading...

dom/plugins/test/testplugin/flashplugin/nptest_name.cpp

Loading...

dom/plugins/test/testplugin/moz.build

Loading...

dom/plugins/test/testplugin/nptest.h

Loading...

dom/plugins/test/testplugin/nptest.cpp

Loading...

dom/plugins/test/testplugin/nptest.def

Loading...

dom/plugins/test/testplugin/nptest.rc

Loading...

dom/plugins/test/testplugin/nptest_droid.cpp

Loading...

dom/plugins/test/testplugin/nptest_gtk2.cpp

Loading...

dom/plugins/test/testplugin/nptest_macosx.mm

Loading...

dom/plugins/test/testplugin/nptest_name.cpp

Loading...

dom/plugins/test/testplugin/nptest_platform.h

Loading...

dom/plugins/test/testplugin/nptest_utils.h

Loading...

dom/plugins/test/testplugin/nptest_utils.cpp

Loading...

dom/plugins/test/testplugin/nptest_windows.cpp

Loading...

dom/plugins/test/testplugin/secondplugin/Info.plist

Loading...

dom/plugins/test/testplugin/secondplugin/moz.build

Loading...

dom/plugins/test/testplugin/secondplugin/nptest.def

Loading...

dom/plugins/test/testplugin/secondplugin/nptest.rc

Loading...

dom/plugins/test/testplugin/secondplugin/nptest_name.cpp

Loading...

dom/plugins/test/testplugin/testplugin.mozbuild

Loading...