Page MenuHomePhabricator

Bug 1525511: Part 4 - Get rid of persona gunk in Telemetry. r=aswan,chutten
ClosedPublic

Authored by kmag on Feb 6 2019, 5:37 AM.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
toolkit/components/telemetry/app/TelemetryEnvironment.jsm
713

This will necessitate a corresponding change to the docs at toolkit/components/telemetry/docs/data/environment.rst

toolkit/components/telemetry/app/TelemetryEnvironment.jsm
713

Last time I removed a field from the docs when I removed it from the ping, I was told not to...

toolkit/components/telemetry/app/TelemetryEnvironment.jsm
713

Odd. The docs should reflect the current state of reporting, so a field no longer sent should no longer be in the docs (except in the Version History at the bottom of the page).

Do you remember when/where that was?

toolkit/components/telemetry/app/TelemetryEnvironment.jsm
713

I may have just been thinking of https://bugzilla.mozilla.org/show_bug.cgi?id=1420908#c6 but I feel like it happened somewhere else too.

toolkit/components/telemetry/app/TelemetryEnvironment.jsm
713

Ah, yes, the old "you can remove the data but changing the shape of it will cost extra". In this case the schema for Environment doesn't require that addons.persona remain (it's not in a required list).

It might be worth an email to fx-data-dev warning of its removal in case there's any ad hoc analyses using it (not that I imagine there are).

But back to the docs: I think it would be wise to remove it and include the removal notice in the Version History. If you don't feel comfortable with that, a comment "removed by bug 1525511 in Firefox 67" would probably do just as well.

aswan added a reviewer: chutten.

Looks good to me but adding @chutten to make sure everything is kosher from the telemetry side.

kmag removed 1 blocking reviewer(s): chutten.
kmag retitled this revision from Bug 1525511: Part 4 - Get rid of persona gunk in Telemetry. r=aswan to Bug 1525511: Part 4 - Get rid of persona gunk in Telemetry. r=aswan,chutten.
This revision is now accepted and ready to land.Feb 6 2019, 9:59 PM

Telemetry bits look good, thanks!